Fix Sodium crash on branches/roots (null material NPE)#1142
Open
crunny wants to merge 1 commit intoDynamicTreesTeam:develop/1.21.1from
Open
Fix Sodium crash on branches/roots (null material NPE)#1142crunny wants to merge 1 commit intoDynamicTreesTeam:develop/1.21.1from
crunny wants to merge 1 commit intoDynamicTreesTeam:develop/1.21.1from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick patch to stop Sodium from crashing with NPE when building chunk meshes for branches, thick branches and surface roots.
#1135
Replaced the null material in
fromVanillacalls with a realRenderMaterialcreated fromRendererAccess.INSTANCE.getRenderer().materialFinder().Disabled AO and diffuse on sprite 0 so branches don't get weird dark corners.
Tested in a jungle biome that was previously crashing - thin branches, thick ones (radius 13+), and surface roots all load without issues now.
Didn't do super heavy testing across every tree type or edge case, but the crash is gone and nothing looks obviously broken.
Please feel free to tweak/improve/revert the shading defaults if needed.